netdev - Re: [PATCH net] net/tls: avoid NULL pointer deref on nskb->sk in fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190501.113842.2247839627720357369.davem@davemloft.net>
Date:   Wed, 01 May 2019 11:38:42 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        borisp@...lanox.com, aviadye@...lanox.com, davejwatson@...com,
        john.fastabend@...il.com, daniel@...earbox.net,
        alexei.starovoitov@...il.com, saeedm@...lanox.com,
        simon.horman@...ronome.com
Subject: Re: [PATCH net] net/tls: avoid NULL pointer deref on nskb->sk in
 fallback

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Mon, 29 Apr 2019 12:19:12 -0700

> update_chksum() accesses nskb->sk before it has been set
> by complete_skb(), move the init up.
> 
> Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Simon Horman <simon.horman@...ronome.com>

Applied and queued up for -stable, thanks.