netdev - Re: [PATCH net] selftests: fib_rule_tests: print the result and return 1 if any tests failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5c3a774-45c4-29fb-ccfd-12051246237d@gmail.com>
Date:   Wed, 1 May 2019 09:48:01 -0600
From:   David Ahern <dsahern@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Roopa Prabhu <roopa@...ulusnetworks.com>,
        David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH net] selftests: fib_rule_tests: print the result and
 return 1 if any tests failed


On 4/29/19 8:46 PM, Hangbin Liu wrote:
> Fixes: 65b2b4939a64 ("selftests: net: initial fib rule tests")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tools/testing/selftests/net/fib_rule_tests.sh | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh
> index d4cfb6a7a086..d84193bdc307 100755
> --- a/tools/testing/selftests/net/fib_rule_tests.sh
> +++ b/tools/testing/selftests/net/fib_rule_tests.sh
> @@ -27,6 +27,7 @@ log_test()
>  		nsuccess=$((nsuccess+1))
>  		printf "\n    TEST: %-50s  [ OK ]\n" "${msg}"
>  	else
> +		ret=1
>  		nfail=$((nfail+1))
>  		printf "\n    TEST: %-50s  [FAIL]\n" "${msg}"
>  		if [ "${PAUSE_ON_FAIL}" = "yes" ]; then
> @@ -245,4 +246,9 @@ setup
>  run_fibrule_tests
>  cleanup
>  
> +if [ "$TESTS" != "none" ]; then
> +	printf "\nTests passed: %3d\n" ${nsuccess}
> +	printf "Tests failed: %3d\n"   ${nfail}
> +fi
> +
>  exit $ret
> 

Thanks for adding the summary.

Reviewed-by: David Ahern <dsahern@...il.com>