netdev - Re: [PATCH v3 net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190501.142948.1053446771181544161.davem@davemloft.net>
Date:   Wed, 01 May 2019 14:29:48 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     grygorii.strashko@...com, ivan.khoronzhuk@...aro.org,
        andrew@...n.ch, ilias.apalodimas@...aro.org, julia.lawall@...6.fr,
        linux-omap@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v3 net-next] net: ethernet: ti: cpsw: Fix inconsistent
 IS_ERR and PTR_ERR in cpsw_probe()

From: YueHaibing <yuehaibing@...wei.com>
Date: Tue, 30 Apr 2019 01:55:24 +0000

> Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe,
> The proper pointer to use is clk instead of mode.
> 
> This issue was detected with the help of Coccinelle.
> 
> Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> ---
> v3: Fix commit log
> v2: add Fixes tag

Applied.