netdev - Re: [PATCH net-next] net: phy: improve resuming from hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190501203424.GG19809@lunn.ch>
Date:   Wed, 1 May 2019 22:34:24 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: improve resuming from hibernation

On Wed, May 01, 2019 at 10:14:21PM +0200, Heiner Kallweit wrote:
> I got an interesting report [0] that after resuming from hibernation
> the link has 100Mbps instead of 1Gbps. Reason is that another OS has
> been used whilst Linux was hibernated. And this OS speeds down the link
> due to WoL. Therefore, when resuming, we shouldn't expect that what
> the PHY advertises is what it did when hibernating.
> Easiest way to do this is removing state PHY_RESUMING. Instead always
> go via PHY_UP that configures PHY advertisement.

Hi Heiner

Going via PHY_UP is reasonable. I'm doing the same in my WIP cable
test code, to restore the PHY after it finishes the test.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew