netdev - Re: [PATCH net-next 1/3] net: hns3: add support for multiple media type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190501123750.GA9844@lunn.ch>
Date:   Wed, 1 May 2019 14:37:50 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Peng Li <lipeng321@...wei.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com
Subject: Re: [PATCH net-next 1/3] net: hns3: add support for multiple media
 type

On Wed, May 01, 2019 at 11:05:42AM +0800, Peng Li wrote:
> From: Jian Shen <shenjian15@...wei.com>
> 
> Previously, we can only identify copper and fiber type, the
> supported link modes of port information are always showing
> SR type. This patch adds support for multiple media types,
> include SR, LR CR, KR. Driver needs to query the media type
> from firmware periodicly, and updates the port information.
> 
> The new port information looks like this:
> Settings for eth0:
>         Supported ports: [ FIBRE ]
>         Supported link modes:   25000baseCR/Full
>                                 25000baseSR/Full
>                                 1000baseX/Full
>                                 10000baseCR/Full
>                                 10000baseSR/Full
>                                 10000baseLR/Full
>         Supported pause frame use: Symmetric
>         Supports auto-negotiation: No
>         Supported FEC modes: None BaseR
>         Advertised link modes:  25000baseCR/Full
>                                 25000baseSR/Full
>                                 1000baseX/Full
>                                 10000baseCR/Full
>                                 10000baseSR/Full
>                                 10000baseLR/Full

Hi Peng

If it does not support auto-negotiation, do these advertised link
modes make any sense? Does it really advertise, or is it all fixed
configured?

	Andrew