netdev - Re: [PATCH v2] rtw88: Make RA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190502162658.A3E5B6083E@smtp.codeaurora.org>
Date:   Thu,  2 May 2019 16:26:58 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Yan-Hsuan Chuang <yhchuang@...ltek.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nathan Chancellor <natechancellor@...il.com>
Subject: Re: [PATCH v2] rtw88: Make RA_MASK macros ULL

Nathan Chancellor <natechancellor@...il.com> wrote:

> Clang warns about the definitions of these macros (full warnings trimmed
> for brevity):
> 
> drivers/net/wireless/realtek/rtw88/main.c:524:15: warning: signed shift
> result (0x3FF00000000) requires 43 bits to represent, but 'int' only has
> 32 bits [-Wshift-overflow]
>                         ra_mask &= RA_MASK_VHT_RATES | RA_MASK_OFDM_IN_VHT;
>                                    ^~~~~~~~~~~~~~~~~
> drivers/net/wireless/realtek/rtw88/main.c:527:15: warning: signed shift
> result (0xFF0000000) requires 37 bits to represent, but 'int' only has
> 32 bits [-Wshift-overflow]
>                         ra_mask &= RA_MASK_HT_RATES | RA_MASK_OFDM_IN_HT_5G;
>                                    ^~~~~~~~~~~~~~~~
> 
> Given that these are all used with ra_mask, which is of type u64, we can
> just declare the macros to be ULL as well.
> 
> Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/467
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Patch applied to wireless-drivers-next.git, thanks.

237b47efcdbc rtw88: Make RA_MASK macros ULL

-- 
https://patchwork.kernel.org/patch/10927105/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches