netdev - Re: [PATCH v4 net-next 00/12] NXP SJA1105 DSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hrBY+TW9cqyovH93HE=Ho26Qdm12s4J4JqMmwNF2YNb6Q@mail.gmail.com>
Date:   Thu, 2 May 2019 20:05:38 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        vivien.didelot@...il.com, netdev <netdev@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 net-next 00/12] NXP SJA1105 DSA driver

On Thu, 2 May 2019 at 19:55, Andrew Lunn <andrew@...n.ch> wrote:
>
> > Wow I am sorry, Gmail apparently moved your reply to spam and I only
> > got it when I posted my message just now.
> > Do you know what causes these whitespace errors, so I can avoid them
> > next time? I think I'm generating my patches rather normally, with
> > $(git format-patch -12 --subject-prefix="PATCH v4 net-next"
> > --cover-letter).
>
> What happens when you run checkpatch on the patches? Does it report
> white space problems.
>
> Another possibility is your email system has mangled the patches.
> First try applying the patches you generated from format-patch to a
> clean tree. If you don't get any warnings, email the patches to
> yourself, and then apply them.
>
>      Andrew

Hi Andrew,

checkpatch.pl --strict doesn't appear to catch this. It looks like
it's caused by introducing new files that are terminated in a blank
line. I will stop doing that.

Thanks,
-Vladimir