netdev - [PATCH net-next] ipmr: Do not define MAXVIFS twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190502222326.2298-1-dsahern@kernel.org>
Date:   Thu,  2 May 2019 15:23:26 -0700
From:   David Ahern <dsahern@...nel.org>
To:     davem@...emloft.net
Cc:     nikolay@...ulusnetworks.com, netdev@...r.kernel.org,
        David Ahern <dsahern@...il.com>
Subject: [PATCH net-next] ipmr: Do not define MAXVIFS twice

From: David Ahern <dsahern@...il.com>

b70432f7319eb refactored mroute code to make it common between ipv4
and ipv6. In the process, MAXVIFS got defined a second time: the
first is in the uapi file linux/mroute.h. A second one was created
presumably for IPv6 but it is not needed. Remove it and have
mroute_base.h include the uapi file directly since it is shared.

include/linux/mroute.h can not be included in mroute_base.h because
it contains a reference to mr_mfc which is defined in mroute_base.h.

Signed-off-by: David Ahern <dsahern@...il.com>
---
 include/linux/mroute_base.h | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/include/linux/mroute_base.h b/include/linux/mroute_base.h
index 34de06b426ef..c5a389f81e91 100644
--- a/include/linux/mroute_base.h
+++ b/include/linux/mroute_base.h
@@ -4,6 +4,7 @@
 #include <linux/netdevice.h>
 #include <linux/rhashtable-types.h>
 #include <linux/spinlock.h>
+#include <uapi/linux/mroute.h>
 #include <net/net_namespace.h>
 #include <net/sock.h>
 #include <net/fib_notifier.h>
@@ -90,13 +91,6 @@ static inline int mr_call_vif_notifiers(struct net *net,
 	return call_fib_notifiers(net, event_type, &info.info);
 }
 
-#ifndef MAXVIFS
-/* This one is nasty; value is defined in uapi using different symbols for
- * mroute and morute6 but both map into same 32.
- */
-#define MAXVIFS	32
-#endif
-
 #define VIF_EXISTS(_mrt, _idx) (!!((_mrt)->vif_table[_idx].dev))
 
 /* mfc_flags:
-- 
2.11.0