netdev - Re: [PATCH v2 6/7] net: Rename skb_frag_t size to bv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201905021743.ZLFmrA34%lkp@intel.com>
Date:   Thu, 2 May 2019 17:49:11 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     kbuild-all@...org, davem@...emloft.net,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>, hch@....de,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 6/7] net: Rename skb_frag_t size to bv_len

Hi Matthew,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on v5.1-rc7]
[cannot apply to next-20190501]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Matthew-Wilcox/Convert-skb_frag_t-to-bio_vec/20190502-161948
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

Note: the linux-review/Matthew-Wilcox/Convert-skb_frag_t-to-bio_vec/20190502-161948 HEAD faadb27a9e0a8480f47f0aca9ca5bee909a63db6 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   In file included from include/linux/kernel.h:15,
                    from include/linux/list.h:9,
                    from include/linux/timer.h:5,
                    from include/linux/workqueue.h:9,
                    from drivers/target/iscsi/cxgbit/cxgbit_target.c:9:
   drivers/target/iscsi/cxgbit/cxgbit_target.c: In function 'cxgbit_lro_skb_dump':
>> drivers/target/iscsi/cxgbit/cxgbit_target.c:1409:52: error: 'skb_frag_t' {aka 'struct skb_frag_struct'} has no member named 'size'
       skb, i, ssi->frags[i].page_offset, ssi->frags[i].size);
                                                       ^
   include/linux/printk.h:309:34: note: in definition of macro 'pr_info'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
                                     ^~~~~~~~~~~
   drivers/target/iscsi/cxgbit/cxgbit_target.c: In function 'cxgbit_lro_skb_merge':
   drivers/target/iscsi/cxgbit/cxgbit_target.c:1453:31: error: 'skb_frag_t' {aka 'struct skb_frag_struct'} has no member named 'size'
      len = hssi->frags[hfrag_idx].size;
                                  ^
   drivers/target/iscsi/cxgbit/cxgbit_target.c:1473:33: error: 'skb_frag_t' {aka 'struct skb_frag_struct'} has no member named 'size'
       len += hssi->frags[dfrag_idx].size;
                                    ^

vim +1409 drivers/target/iscsi/cxgbit/cxgbit_target.c

9730ffcb Varun Prakash 2016-04-20  1388  
9730ffcb Varun Prakash 2016-04-20  1389  static void cxgbit_lro_skb_dump(struct sk_buff *skb)
9730ffcb Varun Prakash 2016-04-20  1390  {
9730ffcb Varun Prakash 2016-04-20  1391  	struct skb_shared_info *ssi = skb_shinfo(skb);
9730ffcb Varun Prakash 2016-04-20  1392  	struct cxgbit_lro_cb *lro_cb = cxgbit_skb_lro_cb(skb);
9730ffcb Varun Prakash 2016-04-20  1393  	struct cxgbit_lro_pdu_cb *pdu_cb = cxgbit_skb_lro_pdu_cb(skb, 0);
9730ffcb Varun Prakash 2016-04-20  1394  	u8 i;
9730ffcb Varun Prakash 2016-04-20  1395  
9730ffcb Varun Prakash 2016-04-20  1396  	pr_info("skb 0x%p, head 0x%p, 0x%p, len %u,%u, frags %u.\n",
9730ffcb Varun Prakash 2016-04-20  1397  		skb, skb->head, skb->data, skb->len, skb->data_len,
9730ffcb Varun Prakash 2016-04-20  1398  		ssi->nr_frags);
9730ffcb Varun Prakash 2016-04-20  1399  	pr_info("skb 0x%p, lro_cb, csk 0x%p, pdu %u, %u.\n",
9730ffcb Varun Prakash 2016-04-20  1400  		skb, lro_cb->csk, lro_cb->pdu_idx, lro_cb->pdu_totallen);
9730ffcb Varun Prakash 2016-04-20  1401  
9730ffcb Varun Prakash 2016-04-20  1402  	for (i = 0; i < lro_cb->pdu_idx; i++, pdu_cb++)
9730ffcb Varun Prakash 2016-04-20  1403  		pr_info("skb 0x%p, pdu %d, %u, f 0x%x, seq 0x%x, dcrc 0x%x, "
9730ffcb Varun Prakash 2016-04-20  1404  			"frags %u.\n",
9730ffcb Varun Prakash 2016-04-20  1405  			skb, i, pdu_cb->pdulen, pdu_cb->flags, pdu_cb->seq,
9730ffcb Varun Prakash 2016-04-20  1406  			pdu_cb->ddigest, pdu_cb->frags);
9730ffcb Varun Prakash 2016-04-20  1407  	for (i = 0; i < ssi->nr_frags; i++)
9730ffcb Varun Prakash 2016-04-20  1408  		pr_info("skb 0x%p, frag %d, off %u, sz %u.\n",
9730ffcb Varun Prakash 2016-04-20 @1409  			skb, i, ssi->frags[i].page_offset, ssi->frags[i].size);
9730ffcb Varun Prakash 2016-04-20  1410  }
9730ffcb Varun Prakash 2016-04-20  1411  

:::::: The code at line 1409 was first introduced by commit
:::::: 9730ffcb8957e1ce9e7d903f7a5db09038a9db8d cxgbit: add files for cxgbit.ko

:::::: TO: Varun Prakash <varun@...lsio.com>
:::::: CC: Nicholas Bellinger <nab@...ux-iscsi.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (56126 bytes)