netdev - Re: [PATCH net-next 02/10] qed: Add llh ppfid interface and 100g support for offload protocols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 May 2019 20:29:40 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Michal Kalderon <michal.kalderon@...vell.com>
Cc:     kbuild-all@...org, michal.kalderon@...vell.com,
        ariel.elior@...vell.com, davem@...emloft.net, jgg@...pe.ca,
        dledford@...hat.com, linux-rdma@...r.kernel.org,
        netdev@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH net-next 02/10] qed: Add llh ppfid interface and 100g
 support for offload protocols

Hi Michal,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Michal-Kalderon/qed-Improve-performance-on-100G-link-for-offload-protocols/20190502-143528
config: x86_64-randconfig-b0-05021924 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_llh_add_mac_filter':
>> drivers/net/ethernet/qlogic/qed/qed_dev.c:981:8: warning: missing braces around initializer [-Wmissing-braces]
     union qed_llh_filter filter = {0};
           ^
   drivers/net/ethernet/qlogic/qed/qed_dev.c:981:8: warning: (near initialization for 'filter.mac') [-Wmissing-braces]
   drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_llh_add_protocol_filter':
   drivers/net/ethernet/qlogic/qed/qed_dev.c:1115:8: warning: missing braces around initializer [-Wmissing-braces]
     union qed_llh_filter filter = {0};
           ^
   drivers/net/ethernet/qlogic/qed/qed_dev.c:1115:8: warning: (near initialization for 'filter.mac') [-Wmissing-braces]
   drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_llh_remove_mac_filter':
   drivers/net/ethernet/qlogic/qed/qed_dev.c:1181:8: warning: missing braces around initializer [-Wmissing-braces]
     union qed_llh_filter filter = {0};
           ^
   drivers/net/ethernet/qlogic/qed/qed_dev.c:1181:8: warning: (near initialization for 'filter.mac') [-Wmissing-braces]
   drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_llh_remove_protocol_filter':
   drivers/net/ethernet/qlogic/qed/qed_dev.c:1232:8: warning: missing braces around initializer [-Wmissing-braces]
     union qed_llh_filter filter = {0};
           ^
   drivers/net/ethernet/qlogic/qed/qed_dev.c:1232:8: warning: (near initialization for 'filter.mac') [-Wmissing-braces]

vim +981 drivers/net/ethernet/qlogic/qed/qed_dev.c

   975	
   976	int qed_llh_add_mac_filter(struct qed_dev *cdev,
   977				   u8 ppfid, u8 mac_addr[ETH_ALEN])
   978	{
   979		struct qed_hwfn *p_hwfn = QED_LEADING_HWFN(cdev);
   980		struct qed_ptt *p_ptt = qed_ptt_acquire(p_hwfn);
 > 981		union qed_llh_filter filter = {0};
   982		u8 filter_idx, abs_ppfid;
   983		u32 high, low, ref_cnt;
   984		int rc = 0;
   985	
   986		if (!p_ptt)
   987			return -EAGAIN;
   988	
   989		if (!test_bit(QED_MF_LLH_MAC_CLSS, &cdev->mf_bits))
   990			goto out;
   991	
   992		memcpy(filter.mac.addr, mac_addr, ETH_ALEN);
   993		rc = qed_llh_shadow_add_filter(cdev, ppfid,
   994					       QED_LLH_FILTER_TYPE_MAC,
   995					       &filter, &filter_idx, &ref_cnt);
   996		if (rc)
   997			goto err;
   998	
   999		/* Configure the LLH only in case of a new the filter */
  1000		if (ref_cnt == 1) {
  1001			rc = qed_llh_abs_ppfid(cdev, ppfid, &abs_ppfid);
  1002			if (rc)
  1003				goto err;
  1004	
  1005			high = mac_addr[1] | (mac_addr[0] << 8);
  1006			low = mac_addr[5] | (mac_addr[4] << 8) | (mac_addr[3] << 16) |
  1007			      (mac_addr[2] << 24);
  1008			rc = qed_llh_add_filter(p_hwfn, p_ptt, abs_ppfid, filter_idx,
  1009						0, high, low);
  1010			if (rc)
  1011				goto err;
  1012		}
  1013	
  1014		DP_VERBOSE(cdev,
  1015			   QED_MSG_SP,
  1016			   "LLH: Added MAC filter [%pM] to ppfid %hhd [abs %hhd] at idx %hhd [ref_cnt %d]\n",
  1017			   mac_addr, ppfid, abs_ppfid, filter_idx, ref_cnt);
  1018	
  1019		goto out;
  1020	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (32094 bytes)