netdev - Re: [PATCH] net: macb: shrink macb_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190503.102651.1150195235857856671.davem@davemloft.net>
Date:   Fri, 03 May 2019 10:26:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     nicolas.ferre@...rochip.com
Cc:     claudiu.beznea@...rochip.com, linux-arm-kernel@...ts.infradead.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        alexandre.belloni@...tlin.com, michal.simek@...inx.com,
        harini.katakam@...inx.com
Subject: Re: [PATCH] net: macb: shrink macb_platform_data structure

From: Nicolas Ferre <nicolas.ferre@...rochip.com>
Date: Fri, 3 May 2019 12:36:58 +0200

> This structure was used intensively for machine specific values
> when DT was not used. Since the removal of AVR32 from the kernel,
> this structure is only used for passing clocks from PCI macb wrapper, all
> other fields being 0.
> All other known platforms use DT.
> 
> Remove the leftovers but make sure that PCI macb still works as
> expected by using default values:
> - phydev->irq is set to PHY_POLL by mdiobus_alloc()
> - mii_bus->phy_mask is cleared while allocating it
> - bp->phy_interface is set to PHY_INTERFACE_MODE_MII if mode not found
> in DT.
> 
> This simplifies driver probe path and particularly phy handling.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Applied.