netdev - Re: [PATCH net] ip6: fix skb leak in ip6frag_expire_frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+cRBCg=7Q4W45z9HuwJoCHspMNRKZJw9ztigjUDryY7w@mail.gmail.com>
Date:   Fri, 3 May 2019 11:52:02 -0400
From:   Eric Dumazet <edumazet@...gle.com>
To:     Peter Oskolkov <posk@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Stfan Bader <stefan.bader@...onical.com>,
        Florian Westphal <fw@...len.de>
Subject: Re: [PATCH net] ip6: fix skb leak in ip6frag_expire_frag_queue()

On Fri, May 3, 2019 at 11:33 AM Peter Oskolkov <posk@...gle.com> wrote:
>
> This skb_get was introduced by commit 05c0b86b9696802fd0ce5676a92a63f1b455bdf3
> "ipv6: frags: rewrite ip6_expire_frag_queue()", and the rbtree patch
> is not in 4.4, where the bug is reported at.
> Shouldn't the "Fixes" tag also reference the original patch?

No, this bug really fixes a memory leak.

Fact that it also fixes the XFRM issue is secondary, since all your
patches are being backported in stable
trees anyway for other reasons.

There is no need to list all commits and give a complete context for a
bug fix like this one,
this would be quite noisy.