netdev - Re: bpftool doc man page build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a2c2f20-ede9-61ae-564a-d44843983f73@netronome.com>
Date:   Fri, 3 May 2019 17:54:47 +0100
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Yonghong Song <yhs@...com>, netdev <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: bpftool doc man page build failure

2019-05-03 16:21 UTC+0000 ~ Yonghong Song <yhs@...com>
> Quentin,
> 
> I hit the following errors with latest bpf-next.
> 
> -bash-4.4$ make man
>    GEN      bpftool-perf.8
>    GEN      bpftool-map.8
>    GEN      bpftool.8
>    GEN      bpftool-net.8
>    GEN      bpftool-feature.8
>    GEN      bpftool-prog.8
>    GEN      bpftool-cgroup.8
>    GEN      bpftool-btf.8
>    GEN      bpf-helpers.rst
> Parsed description of 111 helper function(s)
> Traceback (most recent call last):
>    File "../../../../scripts/bpf_helpers_doc.py", line 421, in <module>
>      printer.print_all()
>    File "../../../../scripts/bpf_helpers_doc.py", line 187, in print_all
>      self.print_one(helper)
>    File "../../../../scripts/bpf_helpers_doc.py", line 378, in print_one
>      self.print_proto(helper)
>    File "../../../../scripts/bpf_helpers_doc.py", line 356, in print_proto
>      proto = helper.proto_break_down()
>    File "../../../../scripts/bpf_helpers_doc.py", line 56, in 
> proto_break_down
>      'type' : capture.group(1),
> AttributeError: 'NoneType' object has no attribute 'group'
> make: *** [bpf-helpers.rst] Error 1
> -bash-4.4$ pwd
> /home/yhs/work/net-next/tools/bpf/bpftool/Documentation
> -bash-4.4$
> 
> Maybe a format issue in the comments with some recent helpers?
> 
> Thanks,
> 
> Yonghong
> 

Hi Yonghong,

Thanks for the notice! Yes, I observed the same thing not long ago. It
seems that the Python script breaks on the "unsigned long" pointer
argument for strtoul(): the script only accepts "const" or "struct" for
types made of several words, not "unsigned".

I'll fix the script so it can take any word and send a patch next week,
along with some other clean-up fixes for the doc.

Best regards,
Quentin