netdev - Re: [PATCH net-next 1/3] net: hns3: add support for multiple media type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <96bbc8c7-0e13-decd-dfb5-ce68df143f39@huawei.com>
Date:   Fri, 3 May 2019 17:54:19 +0800
From:   "lipeng (Y)" <lipeng321@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
        <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>
Subject: Re: [PATCH net-next 1/3] net: hns3: add support for multiple media
 type



On 2019/5/3 11:13, lipeng (Y) wrote:
>
>
> On 2019/5/1 20:37, Andrew Lunn wrote:
>> On Wed, May 01, 2019 at 11:05:42AM +0800, Peng Li wrote:
>>> From: Jian Shen <shenjian15@...wei.com>
>>>
>>> Previously, we can only identify copper and fiber type, the
>>> supported link modes of port information are always showing
>>> SR type. This patch adds support for multiple media types,
>>> include SR, LR CR, KR. Driver needs to query the media type
>>> from firmware periodicly, and updates the port information.
>>>
>>> The new port information looks like this:
>>> Settings for eth0:
>>>          Supported ports: [ FIBRE ]
>>>          Supported link modes:   25000baseCR/Full
>>>                                  25000baseSR/Full
>>>                                  1000baseX/Full
>>>                                  10000baseCR/Full
>>>                                  10000baseSR/Full
>>>                                  10000baseLR/Full
>>>          Supported pause frame use: Symmetric
>>>          Supports auto-negotiation: No
>>>          Supported FEC modes: None BaseR
>>>          Advertised link modes:  25000baseCR/Full
>>>                                  25000baseSR/Full
>>>                                  1000baseX/Full
>>>                                  10000baseCR/Full
>>>                                  10000baseSR/Full
>>>                                  10000baseLR/Full
>> Hi Peng
>>
>> If it does not support auto-negotiation, do these advertised link
>> modes make any sense? Does it really advertise, or is it all fixed
>> configured?
>>
>>     Andrew
>>
>> .
> Hi Andrew:
>
> it makes no sense when auto-negotiation is not supported.
> I should handle it differently with the case supports auto-negotiation
> and not supports auto-negotiation.
>
> I will fix it in next version, result like below:
> Settings for eth0:
>         Supported ports: [ FIBRE ]
>         Supported link modes:   25000baseCR/Full
>                                 25000baseSR/Full
>                                 1000baseX/Full
>                                 10000baseCR/Full
>                                 10000baseSR/Full
>                                 10000baseLR/Full
>         Supported pause frame use: Symmetric
>         Supports auto-negotiation: No
>         Supported FEC modes: None BaseR
>         Advertised link modes:  Not reported
>         Advertised pause frame use: No
>         Advertised auto-negotiation: No
>         Advertised FEC modes: Not reported
>         Speed: 10000Mb/s
>         Duplex: Full
>         Port: FIBRE
>         PHYAD: 0
>         Transceiver: internal
>         Auto-negotiation: off
>         Current message level: 0x00000036 (54)
>                                probe link ifdown ifup
>         Link detected: yes
>
>         Wish I have understood your comments correctly.
>
>
> Thanks!
>

Hi, Andrew:
Thanks for your review. And I have replied your comments.

As this week is 5.1-rc7,  not sure if there is rc8,
I'm sorry for sending V2 patch-set
without waiting for your reply again on V1.

Thanks

>
>>
>
>
>
> .
>