netdev - Re: [PATCH net-next 10/13] net/sched: add block pointer to tc_cls_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190504131654.GJ9049@nanopsycho.orion>
Date:   Sat, 4 May 2019 15:16:54 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, xiyou.wangcong@...il.com,
        idosch@...lanox.com, f.fainelli@...il.com, andrew@...n.ch,
        vivien.didelot@...il.com, gerlitz.or@...il.com,
        simon.horman@...ronome.com,
        Pieter Jansen van Vuuren 
        <pieter.jansenvanvuuren@...ronome.com>
Subject: Re: [PATCH net-next 10/13] net/sched: add block pointer to
 tc_cls_common_offload structure

Sat, May 04, 2019 at 01:46:25PM CEST, jakub.kicinski@...ronome.com wrote:
>From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
>
>Some actions like the police action are stateful and could share state
>between devices. This is incompatible with offloading to multiple devices
>and drivers might want to test for shared blocks when offloading.
>Store a pointer to the tcf_block structure in the tc_cls_common_offload
>structure to allow drivers to determine when offloads apply to a shared
>block.

I don't this this is good idea. If your driver supports shared blocks,
you should register the callback accordingly. See:
mlxsw_sp_setup_tc_block_flower_bind() where tcf_block_cb_lookup() and
__tcf_block_cb_register() are used to achieve that.