lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <c46366ad-8202-76ef-99c9-dc86630208d1@rempel-privat.de> Date: Sat, 4 May 2019 19:45:45 +0200 From: Oleksij Rempel <linux@...pel-privat.de> To: Chuanhong Guo <gch981213@...il.com>, Oleksij Rempel <o.rempel@...gutronix.de> Cc: Paul Burton <paul.burton@...s.com>, Ralf Baechle <ralf@...ux-mips.org>, James Hogan <jhogan@...nel.org>, Rob Herring <robh+dt@...nel.org>, Jay Cliburn <jcliburn@...il.com>, Chris Snook <chris.snook@...il.com>, "David S. Miller" <davem@...emloft.net>, Mark Rutland <mark.rutland@....com>, Pengutronix Kernel Team <kernel@...gutronix.de>, linux-mips@...r.kernel.org, open list <linux-kernel@...r.kernel.org>, devicetree@...r.kernel.org, John Crispin <john@...ozen.org>, Felix Fietkau <nbd@....name>, netdev@...r.kernel.org Subject: Re: [PATCH v3 0/3] MIPS: ath79: add ag71xx support Hi, Am 04.05.19 um 18:01 schrieb Chuanhong Guo: > Hi! > > On Mon, Apr 22, 2019 at 2:41 PM Oleksij Rempel <o.rempel@...gutronix.de> wrote: >> [...] >> - most of deficetree bindings was removed. Not every thing made sense >> and most of it is SoC specific, so it is possible to detect it by >> compatible. > > I noticed that you've dropped all PLL and gmac-config stuff. These are > board-specific properties and PLL registers should be changed > accroding to negotiated ethernet speed. By dropping them, you rely on > bootloader to configure everything corectly for you (which has been > proven unreliable for many ath79 routers) and ethernet won't work if > negotiated speed changed after u-boot's configuration. Both of them should be properly implemented before mainlining. This is the reason why they removed. -- Regards, Oleksij
Powered by blists - more mailing lists