netdev - Re: [Patch net-next] sch_htb: redefine htb qdisc overlimits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f792067-09a7-a645-90be-ffe308c7baf3@gmail.com>
Date:   Sat, 4 May 2019 11:39:20 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [Patch net-next] sch_htb: redefine htb qdisc overlimits



On 5/4/19 2:27 PM, Cong Wang wrote:
> On Sat, May 4, 2019 at 11:10 AM Eric Dumazet <edumazet@...gle.com> wrote:
>>
>> On Sat, May 4, 2019 at 1:49 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
>>
>>> Sure, v2 is coming. :)
>>
>> Another possibility would to reuse existing sch->qstats.overlimits ?
> 
> I don't find any way to retrieve qdisc pointer from struct htb_sched,
> unless we add a pointer there, which will end up bigger.
> 
> Or refactor the functions on the call path of htb_change_class_mode()
> to use struct Qdisc*, which will end up a bigger patch.
> 
> Therefore, I think your suggestion of folding it into 'direct_pkts' is better.
> 
> Thanks.
> 

I see, SGTM then.