netdev - Re: [PATCH hyperv-fixes] hv_netvsc: fix race that may miss tx queue wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190503.235057.2159507077297286948.davem@davemloft.net>
Date:   Fri, 03 May 2019 23:50:57 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     haiyangz@...rosoft.com
Cc:     sashal@...nel.org, linux-hyperv@...r.kernel.org,
        netdev@...r.kernel.org, kys@...rosoft.com, sthemmin@...rosoft.com,
        olaf@...fle.de, vkuznets@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH hyperv-fixes] hv_netvsc: fix race that may miss tx
 queue wakeup

From: Haiyang Zhang <haiyangz@...rosoft.com>
Date: Tue, 30 Apr 2019 19:29:07 +0000

> When the ring buffer is almost full due to RX completion messages, a
> TX packet may reach the "low watermark" and cause the queue stopped.
> If the TX completion arrives earlier than queue stopping, the wakeup
> may be missed.
> 
> This patch moves the check for the last pending packet to cover both
> EAGAIN and success cases, so the queue will be reliably waked up when
> necessary.
> 
> Reported-and-tested-by: Stephan Klein <stephan.klein@...finder.at>
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>

Applied, thanks.