lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190504.004811.237662972933481916.davem@davemloft.net> Date: Sat, 04 May 2019 00:48:11 -0400 (EDT) From: David Miller <davem@...emloft.net> To: hkallweit1@...il.com Cc: andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH v2 net-next] net: phy: improve pause handling From: Heiner Kallweit <hkallweit1@...il.com> Date: Wed, 1 May 2019 21:34:43 +0200 > When probing the phy device we set sym and asym pause in the "supported" > bitmap (unless the PHY tells us otherwise). However we don't know yet > whether the MAC supports pause. Simply copying phy->supported to > phy->advertising will trigger advertising pause, and that's not > what we want. Therefore add phy_advertise_supported() that copies all > modes but doesn't touch the pause bits. > > In phy_support_(a)sym_pause we shouldn't set any bits in the supported > bitmap because we may set a bit the PHY intentionally disabled. > Effective pause support should be the AND-combined PHY and MAC pause > capabilities. If the MAC supports everything, then it's only relevant > what the PHY supports. If MAC supports sym pause only, then we have to > clear the asym bit in phydev->supported. > Copy the pause flags only and don't touch the modes, because a driver > may have intentionally removed a mode from phydev->advertising. > > Signed-off-by: Heiner Kallweit <hkallweit1@...il.com> > --- > v2: > - removed patch 2 from the series Applied.
Powered by blists - more mailing lists