netdev - Re: [PATCH net] ipmr_base: Do not reset index in mr_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190504.013924.1617847326346032679.davem@davemloft.net>
Date:   Sat, 04 May 2019 01:39:24 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH net] ipmr_base: Do not reset index in mr_table_dump

From: David Ahern <dsahern@...nel.org>
Date: Thu,  2 May 2019 15:14:15 -0700

> From: David Ahern <dsahern@...il.com>
> 
> e is the counter used to save the location of a dump when an
> skb is filled. Once the walk of the table is complete, mr_table_dump
> needs to return without resetting that index to 0. Dump of a specific
> table is looping because of the reset because there is no way to
> indicate the walk of the table is done.
> 
> Move the reset to the caller so the dump of each table starts at 0,
> but the loop counter is maintained if a dump fills an skb.
> 
> Fixes: e1cedae1ba6b0 ("ipmr: Refactor mr_rtm_dumproute")
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable.