netdev - Re: [RFC PATCH net-next 2/3] flow_offload: restore ability to collect separate stats per action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190504022759.64232fc0@cakuba.netronome.com>
Date:   Sat, 4 May 2019 02:27:59 -0400
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Edward Cree <ecree@...arflare.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
        "Pablo Neira Ayuso" <pablo@...filter.org>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        Anjali Singhai Jain <anjali.singhai@...el.com>,
        "Or Gerlitz" <gerlitz.or@...il.com>
Subject: Re: [RFC PATCH net-next 2/3] flow_offload: restore ability to
 collect separate stats per action

On Fri, 3 May 2019 16:06:55 +0100, Edward Cree wrote:
> Introduce a new offload command TC_CLSFLOWER_STATS_BYINDEX, similar to
>  the existing TC_CLSFLOWER_STATS but specifying an action_index (the
>  tcfa_index of the action), which is called for each stats-having action
>  on the rule.  Drivers should implement either, but not both, of these
>  commands.
> 
> Signed-off-by: Edward Cree <ecree@...arflare.com>
> ---
>  include/net/pkt_cls.h  |  2 ++
>  net/sched/cls_flower.c | 30 ++++++++++++++++++++++++++++++
>  2 files changed, 32 insertions(+)

It feels a little strange to me to call the new stats updates from
cls_flower, if we really want to support action sharing correctly.

Can RTM_GETACTION not be used to dump actions without dumping the
classifiers?  If we dump from the classifiers wouldn't that lead to
stale stats being returned?