lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <c7a16354-f28d-7c8a-e5f6-41395da53da8@huawei.com> Date: Sat, 4 May 2019 15:08:27 +0800 From: Zhiqiang Liu <liuzhiqiang26@...wei.com> To: Phil Sutter <phil@....cc> CC: <stephen@...workplumber.org>, <liuhangbin@...il.com>, <kuznet@....inr.ac.ru>, <nicolas.dichtel@...nd.com>, "wangxiaogang (F)" <wangxiaogang3@...wei.com>, Mingfangsen <mingfangsen@...wei.com>, "Zhoukang (A)" <zhoukang7@...wei.com>, <kouhuiying@...wei.com>, <netdev@...r.kernel.org> Subject: Re: [PATCH v2] ipnetns: use-after-free problem in get_netnsid_from_name func > Hi, > > On Mon, Apr 29, 2019 at 03:38:39PM +0800, Zhiqiang Liu wrote: >> From: Zhiqiang Liu <liuzhiqiang26@...wei.com> >> >> Follow the following steps: >> # ip netns add net1 >> # export MALLOC_MMAP_THRESHOLD_=0 >> # ip netns list >> then Segmentation fault (core dumped) will occur. >> >> In get_netnsid_from_name func, answer is freed before rta_getattr_u32(tb[NETNSA_NSID]), >> where tb[] refers to answer`s content. If we set MALLOC_MMAP_THRESHOLD_=0, mmap will >> be adoped to malloc memory, which will be freed immediately after calling free func. >> So reading tb[NETNSA_NSID] will access the released memory after free(answer). >> >> Here, we will call get_netnsid_from_name(tb[NETNSA_NSID]) before free(answer). >> >> Fixes: 86bf43c7c2f ("lib/libnetlink: update rtnl_talk to support malloc buff at run time") >> Reported-by: Huiying Kou <kouhuiying@...wei.com> >> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@...wei.com> > > Acked-by: Phil Sutter <phil@....cc> > > Please always Cc: netdev@...r.kernel.org for iproute2 patches. > > Thanks, Phil Thank you for reminding me. I will Cc: netdev@...r.kernel.org in the v3 patch. > > . >
Powered by blists - more mailing lists