lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190504101030.37896-1-yuehaibing@huawei.com> Date: Sat, 4 May 2019 18:10:30 +0800 From: YueHaibing <yuehaibing@...wei.com> To: <davem@...emloft.net>, <michal.simek@...inx.com>, <esben@...nix.com>, <andrew@...n.ch> CC: <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, YueHaibing <yuehaibing@...wei.com> Subject: [PATCH net-next] net: ll_temac: Make some functions static Fix sparse warnings: drivers/net/ethernet/xilinx/ll_temac_main.c:66:5: warning: symbol '_temac_ior_be' was not declared. Should it be static? drivers/net/ethernet/xilinx/ll_temac_main.c:71:6: warning: symbol '_temac_iow_be' was not declared. Should it be static? drivers/net/ethernet/xilinx/ll_temac_main.c:76:5: warning: symbol '_temac_ior_le' was not declared. Should it be static? drivers/net/ethernet/xilinx/ll_temac_main.c:81:6: warning: symbol '_temac_iow_le' was not declared. Should it be static? drivers/net/ethernet/xilinx/ll_temac_main.c:648:6: warning: symbol 'ptr_to_txbd' was not declared. Should it be static? drivers/net/ethernet/xilinx/ll_temac_main.c:654:6: warning: symbol 'ptr_from_txbd' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@...wei.com> Signed-off-by: YueHaibing <yuehaibing@...wei.com> --- drivers/net/ethernet/xilinx/ll_temac_main.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index ca95c72..530a525 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -63,22 +63,22 @@ * Low level register access functions */ -u32 _temac_ior_be(struct temac_local *lp, int offset) +static u32 _temac_ior_be(struct temac_local *lp, int offset) { return ioread32be(lp->regs + offset); } -void _temac_iow_be(struct temac_local *lp, int offset, u32 value) +static void _temac_iow_be(struct temac_local *lp, int offset, u32 value) { return iowrite32be(value, lp->regs + offset); } -u32 _temac_ior_le(struct temac_local *lp, int offset) +static u32 _temac_ior_le(struct temac_local *lp, int offset) { return ioread32(lp->regs + offset); } -void _temac_iow_le(struct temac_local *lp, int offset, u32 value) +static void _temac_iow_le(struct temac_local *lp, int offset, u32 value) { return iowrite32(value, lp->regs + offset); } @@ -645,25 +645,25 @@ static void temac_adjust_link(struct net_device *ndev) #ifdef CONFIG_64BIT -void ptr_to_txbd(void *p, struct cdmac_bd *bd) +static void ptr_to_txbd(void *p, struct cdmac_bd *bd) { bd->app3 = (u32)(((u64)p) >> 32); bd->app4 = (u32)((u64)p & 0xFFFFFFFF); } -void *ptr_from_txbd(struct cdmac_bd *bd) +static void *ptr_from_txbd(struct cdmac_bd *bd) { return (void *)(((u64)(bd->app3) << 32) | bd->app4); } #else -void ptr_to_txbd(void *p, struct cdmac_bd *bd) +static void ptr_to_txbd(void *p, struct cdmac_bd *bd) { bd->app4 = (u32)p; } -void *ptr_from_txbd(struct cdmac_bd *bd) +static void *ptr_from_txbd(struct cdmac_bd *bd) { return (void *)(bd->app4); } -- 2.7.4
Powered by blists - more mailing lists