netdev - Re: [net-next v2 11/11] i40e: Introduce recovery mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190504073522.3bc7e00d@cakuba.netronome.com>
Date:   Sat, 4 May 2019 07:35:22 -0400
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Alice Michael <alice.michael@...el.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, nhorman@...hat.com,
        sassmann@...hat.com, Piotr Marczak <piotr.marczak@...el.com>,
        Don Buchholz <donald.buchholz@...el.com>
Subject: Re: [net-next v2 11/11] i40e: Introduce recovery mode support

On Fri,  3 May 2019 16:09:39 -0700, Jeff Kirsher wrote:
> From: Alice Michael <alice.michael@...el.com>
> 
> This patch introduces "recovery mode" to the i40e driver. It is
> part of a new Any2Any idea of upgrading the firmware. In this
> approach, it is required for the driver to have support for
> "transition firmware", that is used for migrating from structured
> to flat firmware image. In this new, very basic mode, i40e driver
> must be able to handle particular IOCTL calls from the NVM Update
> Tool and run a small set of AQ commands.

What's the "particular IOCTL" you speak of?  This patch adds a fake
netdev with a .set_eeprom callback.  Are you wrapping the AQ commands
in the set_eeprom now?  Or is there some other IOCTL here?

Let me repeat my other question - can the netdev you spawn in
i40e_init_recovery_mode() pass traffic?

> These additional AQ commands are part of the interface used by
> the NVMUpdate tool.  The NVMUpdate tool contains all of the
> necessary logic to reference these new AQ commands.  The end user
> experience remains the same, they are using the NVMUpdate tool to
> update the NVM contents.

IOW to update FW users still need your special tool, but they can use
ethtool -f to.. change the app-specific (DPDK) parser profiles?  Joy :)

> Signed-off-by: Alice Michael <alice.michael@...el.com>
> Signed-off-by: Piotr Marczak <piotr.marczak@...el.com>
> Tested-by: Don Buchholz <donald.buchholz@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>