netdev - Re: [PATCH v3] net: dccp: Checksum verification enhancement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 05 May 2019 09:53:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Markus.Amend@...ekom.de
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        dccp@...r.kernel.org
Subject: Re: [PATCH v3] net: dccp: Checksum verification enhancement

From: <Markus.Amend@...ekom.de>
Date: Tue, 30 Apr 2019 16:11:07 +0000

> The current patch modifies the checksum verification of a received DCCP
> packet, by adding the function __skb_checksum_validate into the
> dccp_vX_rcv routine. The purpose of the modification is to allow the
> verification of the skb->ip_summed flags during the checksum validation
> process (for checksum offload purposes). As __skb_checksum_validate
> covers the functionalities of skb_checksum and dccp_vX_csum_finish they
> are needless and therefore removed.
> 
> Signed-off-by: Nathalie Romo Moreno <natha.ro.moreno@...il.com>
> Signed-off-by: Markus Amend <markus.amend@...ekom.de>

I don't see how this can be correct as you're not taking the csum
coverage value into consideration at all.