netdev - Re: [PATCH 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 5 May 2019 23:03:57 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Ruslan Babayev <ruslan@...ayev.com>,
        Russell King <linux@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     xe-linux-external@...co.com,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based
 systems

On 05.05.2019 22:51, Ruslan Babayev wrote:
> Lookup I2C adapter using the "i2c-bus" device property on ACPI based
> systems similar to how it's done with DT.
> 
> An example DSD describing an SFP on an ACPI based system:
> 
> Device (SFP0)
> {
>     Name (_HID, "PRP0001")
>     Name (_DSD, Package ()
>     {
>         ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>         Package () {
>             Package () { "compatible", "sff,sfp" },
>             Package () { "i2c-bus", \_SB.PCI0.RP01.I2C.MUX.CH0 },
>         },
>     })
> }
> 
> Signed-off-by: Ruslan Babayev <ruslan@...ayev.com>
> Cc: xe-linux-external@...co.com
> ---
>  drivers/net/phy/sfp.c | 33 +++++++++++++++++++++++++--------
>  1 file changed, 25 insertions(+), 8 deletions(-)
> 
If we have a patch series touching more than one sub-system a typical
approach is:
- Send series to all persons / lists being responsible for the affected
  subsystems
- Maintainers will agree through which tree the series will go
- Maintainers of the other subsystems will ACK their respective patches
  of the series

I just received patch 2/2. The complete series (cover letter + two patches)
should have gone to i2c and phylib maintainers + lists.

As an additional hint regarding the commit message:
I suppose you added this code to support a specific device. Wouldn't hurt
if you mention which device it is.