[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 5 May 2019 14:22:16 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Hauke Mehrtens <hauke@...ke-m.de>, davem@...emloft.net
Cc: andrew@...n.ch, vivien.didelot@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 5/5] net: dsa: lantiq: Add Forwarding Database access
On 5/5/2019 2:15 PM, Hauke Mehrtens wrote:
> This adds functions to add and remove static entries to and from the
> forwarding database and dump the full forwarding database.
>
> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
> ---
[snip]
> + mac_bridge.table = 0x0b;
> + mac_bridge.key_mode = true;
> + mac_bridge.key[0] = addr[5] | (addr[4] << 8);
> + mac_bridge.key[1] = addr[3] | (addr[2] << 8);
> + mac_bridge.key[2] = addr[1] | (addr[0] << 8);
> + mac_bridge.key[3] = fid;
> + mac_bridge.val[0] = add ? BIT(port) : 0; /* port map */
> + mac_bridge.val[1] = 0x01; /* static entry */
Could you add a define for that bit?
[snip]
> + addr[0] = (mac_bridge.key[2] >> 8) & 0xff;
> + if (mac_bridge.val[1] & 0x01) {
And use it here as well? The rest looks fine to me, so if you fix that:
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian
Powered by blists - more mailing lists