netdev - Re: [PATCH bpf 0/2] libbpf: fixes for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+Jas=-sJyPRDA-79EQFfZAzjJAiXLwxZUkmv9MS+dLmQ@mail.gmail.com>
Date:   Sat, 4 May 2019 23:30:04 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jonathan Lemon <jlemon@...gsvamp.com>
Cc:     Björn Töpel <bjorn.topel@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Magnus Karlsson <magnus.karlsson@...il.com>,
        bpf <bpf@...r.kernel.org>, William Tu <u9012063@...il.com>
Subject: Re: [PATCH bpf 0/2] libbpf: fixes for AF_XDP teardown

On Tue, Apr 30, 2019 at 8:38 AM Jonathan Lemon <jlemon@...gsvamp.com> wrote:
>
>
>
> On 30 Apr 2019, at 5:45, Björn Töpel wrote:
>
> > William found two bugs, when doing socket teardown within the same
> > process.
> >
> > The first issue was an invalid munmap call, and the second one was an
> > invalid XSKMAP cleanup. Both resulted in that the process kept
> > references to the socket, which was not correctly cleaned up. When a
> > new socket was created, the bind() call would fail, since the old
> > socket was still lingering, refusing to give up the queue on the
> > netdev.
> >
> > More details can be found in the individual commits.
>
> Reviewed-by: Jonathan Lemon <jonathan.lemon@...il.com>

Applied. Thanks!