netdev - Re: [PATCH net] vrf: sit mtu should not be updated when vrf netdev is the link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <667fd9b5-6122-bd9f-e6ae-e08d82197ef9@gmail.com>
Date:   Mon, 6 May 2019 13:54:16 -0600
From:   David Ahern <dsahern@...il.com>
To:     Stephen Suryaputra <ssuryaextr@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] vrf: sit mtu should not be updated when vrf netdev is
 the link

On 5/6/19 1:00 PM, Stephen Suryaputra wrote:
> VRF netdev mtu isn't typically set and have an mtu of 65536. When the
> link of a tunnel is set, the tunnel mtu is changed from 1480 to the link
> mtu minus tunnel header. In the case of VRF netdev is the link, then the
> tunnel mtu becomes 65516. So, fix it by not setting the tunnel mtu in
> this case.
> 
> Signed-off-by: Stephen Suryaputra <ssuryaextr@...il.com>
> ---
>  net/ipv6/sit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
> index b2109b74857d..971d60bf9640 100644
> --- a/net/ipv6/sit.c
> +++ b/net/ipv6/sit.c
> @@ -1084,7 +1084,7 @@ static void ipip6_tunnel_bind_dev(struct net_device *dev)
>  	if (!tdev && tunnel->parms.link)
>  		tdev = __dev_get_by_index(tunnel->net, tunnel->parms.link);
>  
> -	if (tdev) {
> +	if (tdev && !netif_is_l3_master(tdev)) {
>  		int t_hlen = tunnel->hlen + sizeof(struct iphdr);
>  
>  		dev->hard_header_len = tdev->hard_header_len + sizeof(struct iphdr);
> 

can you explain how tdev is a VRF device? What's the config setup for
this case?