netdev - Re: [bpf-next PATCH v3 0/4] sockmap/ktls fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1bf04abf-478b-28c3-21df-0be049074f0f@iogearbox.net>
Date:   Mon, 6 May 2019 11:18:43 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     John Fastabend <john.fastabend@...il.com>,
        jakub.kicinski@...ronome.com, ast@...nel.org
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [bpf-next PATCH v3 0/4] sockmap/ktls fixes

On 05/02/2019 10:05 PM, John Fastabend wrote:
> On 4/30/19 7:06 PM, John Fastabend wrote:
>> Series of fixes for sockmap and ktls, see patches for descriptions.
>>
>> v2: fix build issue for CONFIG_TLS_DEVICE and fixup couple comments
>>     from Jakub
>>
>> v3: fix issue where release could call unhash resulting in a use after
>>     free. Now we detach the ulp pointer before calling into destroy
>>     or unhash. This way if we get a callback into unhash from destroy
>>     path there is no ulp to access. The fallout is we must pass the
>>     ctx into the functions rather than use the sk lookup in each
>>     routine. This is probably better anyways.
>>
>>     @Jakub, I did not fix the hw device case it seems the ulp ptr is
>>     needed for the hardware teardown but this is buggy for sure. Its
>>     not clear to me how to resolve the hw issue at the moment so fix
>>     the sw path why we discuss it.
>>
> Unfortunately, this is still failing with hardware offload (thanks
> Jakub) so will need a v4 to actually fix this.

Perhaps split off the skmsg fixes from the series so they can already
be applied since they should be independent of the tlx fix?

Thanks,
Daniel