lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 May 2019 15:16:05 +0200 From: Pablo Neira Ayuso <pablo@...filter.org> To: Nicolas Dichtel <nicolas.dichtel@...nd.com> Cc: Kristian Evensen <kristian.evensen@...il.com>, netdev@...r.kernel.org, netfilter-devel@...r.kernel.org Subject: Re: [PATCH] netfilter: ctnetlink: Resolve conntrack L3-protocol flush regression On Mon, May 06, 2019 at 10:49:52AM +0200, Nicolas Dichtel wrote: > Le 06/05/2019 à 00:32, Pablo Neira Ayuso a écrit : > > On Fri, May 03, 2019 at 05:40:07PM +0200, Kristian Evensen wrote: > >> Commit 59c08c69c278 ("netfilter: ctnetlink: Support L3 protocol-filter > >> on flush") introduced a user-space regression when flushing connection > >> track entries. Before this commit, the nfgen_family field was not used > >> by the kernel and all entries were removed. Since this commit, > >> nfgen_family is used to filter out entries that should not be removed. > >> One example a broken tool is conntrack. conntrack always sets > >> nfgen_family to AF_INET, so after 59c08c69c278 only IPv4 entries were > >> removed with the -F parameter. > >> > >> Pablo Neira Ayuso suggested using nfgenmsg->version to resolve the > >> regression, and this commit implements his suggestion. nfgenmsg->version > >> is so far set to zero, so it is well-suited to be used as a flag for > >> selecting old or new flush behavior. If version is 0, nfgen_family is > >> ignored and all entries are used. If user-space sets the version to one > >> (or any other value than 0), then the new behavior is used. As version > >> only can have two valid values, I chose not to add a new > >> NFNETLINK_VERSION-constant. > > > > Applied, thanks. > > > Thank you. > Is it possible to queue this for stable? Sure, as soon as this hits Linus' tree.
Powered by blists - more mailing lists