netdev - Re: [net-next 09/15] net/mlx5: Create FW devlink health reporter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190506171122.5ea54733@cakuba.hsd1.ca.comcast.net>
Date:   Mon, 6 May 2019 17:11:22 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Moshe Shemesh <moshe@...lanox.com>,
        Eran Ben Elisha <eranbe@...lanox.com>
Subject: Re: [net-next 09/15] net/mlx5: Create FW devlink health reporter

On Sun, 5 May 2019 00:33:23 +0000, Saeed Mahameed wrote:
> From: Moshe Shemesh <moshe@...lanox.com>
> 
> Create mlx5_devlink_health_reporter for FW reporter. The FW reporter
> implements devlink_health_reporter diagnose callback.
> 
> The fw reporter diagnose command can be triggered any time by the user
> to check current fw status.
> In healthy status, it will return clear syndrome. Otherwise it will dump
> the health info buffer.
> 
> Command example and output on healthy status:
> $ devlink health diagnose pci/0000:82:00.0 reporter fw
> Syndrome: 0
> 
> Command example and output on non healthy status:
> $ devlink health diagnose pci/0000:82:00.0 reporter fw
> diagnose data:
> assert_var[0] 0xfc3fc043
> assert_var[1] 0x0001b41c
> assert_var[2] 0x00000000
> assert_var[3] 0x00000000
> assert_var[4] 0x00000000
> assert_exit_ptr 0x008033b4
> assert_callra 0x0080365c
> fw_ver 16.24.1000

Does FW version really have to be duplicated in this API?

> hw_id 0x0000020d
> irisc_index 0
> synd 0x8: unrecoverable hardware error
> ext_synd 0x003d
> raw fw_ver 0x101803e8