netdev - Re: [PATCH pppd v4] pppoe: custom host-uniq tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190507093932.GB3561@jackdaw>
Date:   Tue, 7 May 2019 10:39:33 +0100
From:   Tom Parkin <tparkin@...alix.com>
To:     Matteo Croce <mcroce@...hat.com>
Cc:     linux-ppp@...r.kernel.org, netdev <netdev@...r.kernel.org>,
        Paul Mackerras <paulus@...abs.org>,
        Jo-Philipp Wich <jo@...n.io>
Subject: Re: [PATCH pppd v4] pppoe: custom host-uniq tag

On Tue, May 07, 2019 at 11:32:27AM +0200, Matteo Croce wrote:
> On Tue, May 7, 2019 at 11:10 AM Tom Parkin <tparkin@...alix.com> wrote:
> >
> > Hi Matteo,
> >
> > On Sat, May 04, 2019 at 06:48:53PM +0200, Matteo Croce wrote:
> > > Add pppoe 'host-uniq' option to set an arbitrary
> > > host-uniq tag instead of the pppd pid.
> > > Some ISPs use such tag to authenticate the CPE,
> > > so it must be set to a proper value to connect.
> > >
> > > Signed-off-by: Matteo Croce <mcroce@...hat.com>
> > > Signed-off-by: Jo-Philipp Wich <jo@...n.io>
> > > ---
> > >  pppd/plugins/rp-pppoe/common.c          | 14 +++----
> > >  pppd/plugins/rp-pppoe/discovery.c       | 52 ++++++++++---------------
> > >  pppd/plugins/rp-pppoe/plugin.c          | 15 ++++++-
> > >  pppd/plugins/rp-pppoe/pppoe-discovery.c | 41 ++++++++++++-------
> > >  pppd/plugins/rp-pppoe/pppoe.h           | 30 +++++++++++++-
> > >  5 files changed, 96 insertions(+), 56 deletions(-)
> > >
> 
> Hi Tom,
> 
> this was a known bug of the v3 patch, I've fixed it in the v4.
> 
> Regards,

Cool, thanks for confirming.

Tom

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)