netdev - Re: [PATCH net] selinux: do not report error on connect(AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190508.094628.1716602477350359336.davem@davemloft.net>
Date:   Wed, 08 May 2019 09:46:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     paul@...l-moore.com, selinux@...r.kernel.org,
        netdev@...r.kernel.org, tdeseyn@...hat.com,
        marcelo.leitner@...il.com, richard_c_haines@...nternet.com
Subject: Re: [PATCH net] selinux: do not report error on connect(AF_UNSPEC)

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed,  8 May 2019 15:32:51 +0200

> calling connect(AF_UNSPEC) on an already connected TCP socket is an
> established way to disconnect() such socket. After commit 68741a8adab9
> ("selinux: Fix ltp test connect-syscall failure") it no longer works
> and, in the above scenario connect() fails with EAFNOSUPPORT.
> 
> Fix the above falling back to the generic/old code when the address family
> is not AF_INET{4,6}, but leave the SCTP code path untouched, as it has
> specific constraints.
> 
> Fixes: 68741a8adab9 ("selinux: Fix ltp test connect-syscall failure")
> Reported-by: Tom Deseyn <tdeseyn@...hat.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied, and queued up for -stable, thanks!