lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190508.131357.1972863276402672227.davem@davemloft.net> Date: Wed, 08 May 2019 13:13:57 -0700 (PDT) From: David Miller <davem@...emloft.net> To: colin.king@...onical.com Cc: olteanv@...il.com, andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH][V3] net: dsa: sja1105: fix check on while loop exit From: Colin King <colin.king@...onical.com> Date: Wed, 8 May 2019 14:30:41 +0100 > From: Colin Ian King <colin.king@...onical.com> > > The while-loop exit condition check is not correct; the > loop should continue if the returns from the function calls are > negative or the CRC status returns are invalid. Currently it > is ignoring the returns from the function calls. Fix this by > removing the status return checks and only break from the loop > at the very end when we know that all the success condtions have > been met. > > Kudos to Dan Carpenter for describing the correct fix and > Vladimir Oltean for noting the change to the check on the number > of retries. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch") > Signed-off-by: Colin Ian King <colin.king@...onical.com> > Tested-by: Vladimir Oltean <olteanv@...il.com> Applied, thank you.
Powered by blists - more mailing lists