lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190508.135808.610382717397984273.davem@davemloft.net> Date: Wed, 08 May 2019 13:58:08 -0700 (PDT) From: David Miller <davem@...emloft.net> To: olteanv@...il.com Cc: dan.carpenter@...cle.com, f.fainelli@...il.com, vivien.didelot@...il.com, andrew@...n.ch, kernel-janitors@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] net: dsa: sja1105: Don't return a negative in u8 sja1105_stp_state_get From: Vladimir Oltean <olteanv@...il.com> Date: Wed, 8 May 2019 23:32:25 +0300 > Dan Carpenter says: > > The patch 640f763f98c2: "net: dsa: sja1105: Add support for Spanning > Tree Protocol" from May 5, 2019, leads to the following static > checker warning: > > drivers/net/dsa/sja1105/sja1105_main.c:1073 sja1105_stp_state_get() > warn: signedness bug returning '(-22)' > > The caller doesn't check for negative errors anyway. > > Fixes: 640f763f98c2: ("net: dsa: sja1105: Add support for Spanning Tree Protocol") > Reported-by: Dan Carpenter <dan.carpenter@...cle.com> > Signed-off-by: Vladimir Oltean <olteanv@...il.com> Applied.
Powered by blists - more mailing lists