netdev - Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190508014159.GM18865@dhcp-12-139.nay.redhat.com>
Date:   Wed, 8 May 2019 09:41:59 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Miroslav Lichvar <mlichvar@...hat.com>
Cc:     Richard Cochran <richardcochran@...il.com>,
        Jiri Benc <jbenc@...hat.com>, netdev@...r.kernel.org,
        David Miller <davem@...emloft.net>,
        Patrick McHardy <kaber@...sh.net>,
        stefan.sorensen@...ctralink.com
Subject: Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP
 ioctl to real device

On Tue, May 07, 2019 at 10:35:59AM +0200, Miroslav Lichvar wrote:
> On Mon, May 06, 2019 at 07:01:23AM -0700, Richard Cochran wrote:
> > On Thu, Apr 25, 2019 at 09:40:06PM +0800, Hangbin Liu wrote:
> > > Would you please help have a look at it and see which way we should use?
> > > Drop SIOCSHWTSTAMP in container or add a filter on macvlan(maybe only in
> > > container)?
> > 
> > I vote for dropping SIOCSHWTSTAMP altogether.  Why?  Because the
> > filter idea means that the ioctl will magically succeed or fail, based
> > on the unknowable state of the container's host.
> 
> That's a good point. I agree that SIOCSHWTSTAMP always failing would
> be a less surprising behavior than failing only with some specific
> configurations.

Thanks for the reply. As net-next is closed now. I will post the fix
to net branch after merging finished.

Cheers
Hangbin