netdev - Re: [PATCH net] net/tcp: use deferred jump label for TCP acked data hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190509.094619.2211366094183779478.davem@davemloft.net>
Date:   Thu, 09 May 2019 09:46:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     oss-drivers@...ronome.com, netdev@...r.kernel.org,
        edumazet@...gle.com, simon.horman@...ronome.com
Subject: Re: [PATCH net] net/tcp: use deferred jump label for TCP acked
 data hook

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Wed,  8 May 2019 16:46:14 -0700

> User space can flip the clean_acked_data_enabled static branch
> on and off with TLS offload when CONFIG_TLS_DEVICE is enabled.
> jump_label.h suggests we use the delayed version in this case.
> 
> Deferred branches now also don't take the branch mutex on
> decrement, so we avoid potential locking issues.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Simon Horman <simon.horman@...ronome.com>

Eric, please review.