netdev - Re: [PATCH RFC net-next] netlink: Add support for timestamping messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190509.095134.1780905261988048160.davem@davemloft.net>
Date:   Thu, 09 May 2019 09:51:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, dsahern@...il.com
Subject: Re: [PATCH RFC net-next] netlink: Add support for timestamping
 messages

From: David Ahern <dsahern@...nel.org>
Date: Thu,  9 May 2019 08:55:42 -0700

> From: David Ahern <dsahern@...il.com>
> 
> Add support for timestamping netlink messages. If a socket wants a
> timestamp, it is added when the skb clone is queued to the socket.
> 
> Allow userspace to know the actual time an event happened. In a
> busy system there can be a long lag between when the event happened
> and when the message is read from the socket. Further, this allows
> separate netlink sockets for various RTNLGRP's where the timestamp
> can be used to sort the messages if needed.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> ---
> one question I have is whether it would be better to add the timestamp
> when the skb is created so it is the same for all sockets as opposed to
> setting the time per socket.

If the importance is that the timestamp is when the "event" occurs
then you should set it at skb creation time.