netdev - [PATCH net-next] sctp: remove unused cmd SCTP_CMD_GEN_INIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu,  9 May 2019 14:28:00 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org
Cc:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Neil Horman <nhorman@...driver.com>, davem@...emloft.net
Subject: [PATCH net-next] sctp: remove unused cmd SCTP_CMD_GEN_INIT_ACK

SCTP_CMD_GEN_INIT_ACK was introduced since very beginning, but never
got used. So remove it.

Signed-off-by: Xin Long <lucien.xin@...il.com>
---
 include/net/sctp/command.h |  1 -
 net/sctp/sm_sideeffect.c   | 11 -----------
 2 files changed, 12 deletions(-)

diff --git a/include/net/sctp/command.h b/include/net/sctp/command.h
index 6d5beac..b4e8706 100644
--- a/include/net/sctp/command.h
+++ b/include/net/sctp/command.h
@@ -48,7 +48,6 @@ enum sctp_verb {
 	SCTP_CMD_REPORT_TSN,	/* Record the arrival of a TSN.  */
 	SCTP_CMD_GEN_SACK,	/* Send a Selective ACK (maybe).  */
 	SCTP_CMD_PROCESS_SACK,	/* Process an inbound SACK.  */
-	SCTP_CMD_GEN_INIT_ACK,	/* Generate an INIT ACK chunk.  */
 	SCTP_CMD_PEER_INIT,	/* Process a INIT from the peer.  */
 	SCTP_CMD_GEN_COOKIE_ECHO, /* Generate a COOKIE ECHO chunk. */
 	SCTP_CMD_CHUNK_ULP,	/* Send a chunk to the sockets layer.  */
diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
index 4aa0358..233ee80 100644
--- a/net/sctp/sm_sideeffect.c
+++ b/net/sctp/sm_sideeffect.c
@@ -1364,17 +1364,6 @@ static int sctp_cmd_interpreter(enum sctp_event_type event_type,
 						      cmd->obj.chunk);
 			break;
 
-		case SCTP_CMD_GEN_INIT_ACK:
-			/* Generate an INIT ACK chunk.  */
-			new_obj = sctp_make_init_ack(asoc, chunk, GFP_ATOMIC,
-						     0);
-			if (!new_obj)
-				goto nomem;
-
-			sctp_add_cmd_sf(commands, SCTP_CMD_REPLY,
-					SCTP_CHUNK(new_obj));
-			break;
-
 		case SCTP_CMD_PEER_INIT:
 			/* Process a unified INIT from the peer.
 			 * Note: Only used during INIT-ACK processing.  If
-- 
2.1.0