lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 9 May 2019 08:17:02 +0000
From:   Jose Abreu <>
To:     Andrew Lunn <>, Jose Abreu <>
CC:     "" <>,
        "" <>,
        Joao Pinto <>,
        "David S . Miller" <>,
        Giuseppe Cavallaro <>,
        Alexandre Torgue <>
Subject: RE: [PATCH net-next 00/11] net: stmmac: Selftests

From: Andrew Lunn <>
Date: Wed, May 08, 2019 at 20:50:11

> The normal operation is interrupted by the tests you carry out
> here. But i don't see any code looking for ETH_TEST_FL_OFFLINE

Ok will fix to only run in offline mode then.

> > (Error code -95 means EOPNOTSUPP in current HW).
> How deep do you have to go before you know about EOPNOTSUPP?  It would
> be better to not return the string and result at all. Or patch ethtool
> to call strerror(3).

When I looked at other drivers I saw that they return positive value (1) 
or zero so calling strerror in ethtool may not be ideal.

I think its useful to let the user know if a given test is not supported 
in HW so maybe I can return 1 instead of EOPNOTSUPP ?

Jose Miguel Abreu

Powered by blists - more mailing lists