netdev - Re: [PATCH net] macvlan: disable SIOCSHWTSTAMP in container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190509135201.esaftnkmdehlzp77@localhost>
Date:   Thu, 9 May 2019 06:52:01 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, Miroslav Lichvar <mlichvar@...hat.com>,
        Jiri Benc <jbenc@...hat.com>,
        Michal Kubecek <mkubecek@...e.cz>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH net] macvlan: disable SIOCSHWTSTAMP in container

On Thu, May 09, 2019 at 02:54:08PM +0800, Hangbin Liu wrote:
> Miroslav pointed that with NET_ADMIN enabled in container, a normal user
> could be mapped to root and is able to change the real device's rx
> filter via ioctl on macvlan, which would affect the other ptp process on
> host. Fix it by disabling SIOCSHWTSTAMP in container.
> 
> Fixes: 254c0a2bfedb ("macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Acked-by: Richard Cochran <richardcochran@...il.com>