netdev - Re: [PATCH net v1] tipc: fix hanging clients using poll with EPOLLOUT flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190509.092729.490057205840616989.davem@davemloft.net>
Date:   Thu, 09 May 2019 09:27:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     parthasarathy.bhuvaragan@...il.com
Cc:     netdev@...r.kernel.org, jon.maloy@...csson.com,
        ying.xue@...driver.com, tipc-discussion@...ts.sourceforge.net,
        jon.maloy@...csson.se
Subject: Re: [PATCH net v1] tipc: fix hanging clients using poll with
 EPOLLOUT flag

From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...il.com>
Date: Thu,  9 May 2019 07:13:42 +0200

> commit 517d7c79bdb398 ("tipc: fix hanging poll() for stream sockets")
> introduced a regression for clients using non-blocking sockets.
> After the commit, we send EPOLLOUT event to the client even in
> TIPC_CONNECTING state. This causes the subsequent send() to fail
> with ENOTCONN, as the socket is still not in TIPC_ESTABLISHED state.
> 
> In this commit, we:
> - improve the fix for hanging poll() by replacing sk_data_ready()
>   with sk_state_change() to wake up all clients.
> - revert the faulty updates introduced by commit 517d7c79bdb398
>   ("tipc: fix hanging poll() for stream sockets").
> 
> Fixes: 517d7c79bdb398 ("tipc: fix hanging poll() for stream sockets")
> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...il.com>
> Acked-by: Jon Maloy <jon.maloy@...csson.se>

Applied and queued up for -stable.