lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 May 2019 00:00:30 +0000 From: Alakesh Haloi <alakesh.haloi@...il.com> To: Alexei Starovoitov <alexei.starovoitov@...il.com> Cc: Shuah Khan <shuah@...nel.org>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, Network Development <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] selftests/bpf: Fix compile warning in bpf selftest On Thu, May 09, 2019 at 01:51:54PM -0700, Alexei Starovoitov wrote: > On Tue, May 7, 2019 at 4:12 PM Alakesh Haloi <alakesh.haloi@...il.com> wrote: > > > > This fixes the following compile time warning > > > > flow_dissector_load.c: In function ‘detach_program’: > > flow_dissector_load.c:55:19: warning: format not a string literal and no format arguments [-Wformat-security] > > error(1, errno, command); > > ^~~~~~~ > > Signed-off-by: Alakesh Haloi <alakesh.haloi@...il.com> > > --- > > tools/testing/selftests/bpf/flow_dissector_load.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/bpf/flow_dissector_load.c b/tools/testing/selftests/bpf/flow_dissector_load.c > > index 77cafa66d048..7136ab9ffa73 100644 > > --- a/tools/testing/selftests/bpf/flow_dissector_load.c > > +++ b/tools/testing/selftests/bpf/flow_dissector_load.c > > @@ -52,7 +52,7 @@ static void detach_program(void) > > sprintf(command, "rm -r %s", cfg_pin_path); > > ret = system(command); > > if (ret) > > - error(1, errno, command); > > + error(1, errno, "%s", command); > > } > > it was fixed month ago. The warning is seen in mainline. I did not try bpf tree. Looks like it is fixed there. Thanks -Alakesh
Powered by blists - more mailing lists