netdev - Re: [PATCH net 2/3] of_net: add property "nvmem-mac-address" for of_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190510181758.GF11588@lunn.ch>
Date:   Fri, 10 May 2019 20:17:58 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Andy Duan <fugang.duan@....com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "ynezz@...e.cz" <ynezz@...e.cz>,
        "john@...ozen.org" <john@...ozen.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>
Subject: Re: [PATCH net 2/3] of_net: add property "nvmem-mac-address" for
 of_get_mac_addr()

On Fri, May 10, 2019 at 08:24:03AM +0000, Andy Duan wrote:
> If MAC address read from nvmem cell and it is valid mac address,
> .of_get_mac_addr_nvmem() add new property "nvmem-mac-address" in
> ethernet node. Once user call .of_get_mac_address() to get MAC
> address again, it can read valid MAC address from device tree in
> directly.

I suspect putting the MAC address into OF will go away in a follow up
patch. It is a bad idea.

       Andrew