[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20190510.132800.1971158293891484440.davem@davemloft.net>
Date: Fri, 10 May 2019 13:28:00 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: hofrat@...dl.org
Cc: aneela@...eaurora.org, gregkh@...uxfoundation.org,
anshuman.khandual@....com, david@...hat.com, arnd@...db.de,
johannes.berg@...el.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: qrtr: use protocol endiannes variable
From: Nicholas Mc Guire <hofrat@...dl.org>
Date: Fri, 10 May 2019 03:08:53 +0200
> diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
> index dd0e97f..c90edaa 100644
> --- a/net/qrtr/qrtr.c
> +++ b/net/qrtr/qrtr.c
> @@ -733,7 +733,8 @@ static int qrtr_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)
> struct qrtr_node *node;
> struct sk_buff *skb;
> size_t plen;
> - u32 type = QRTR_TYPE_DATA;
> + u32 type = 0;
> + __le32 qrtr_type = cpu_to_le32(QRTR_TYPE_DATA);
> int rc;
Please try to preserve as much of the reverse chrimstas tree here rather
than making it worse.
Thank you.
Powered by blists - more mailing lists