lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 May 2019 15:07:26 -0700 (PDT) From: David Miller <davem@...emloft.net> To: yuehaibing@...wei.com Cc: andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] dsa: tag_brcm: Fix build error without CONFIG_NET_DSA_TAG_BRCM_PREPEND From: YueHaibing <yuehaibing@...wei.com> Date: Fri, 10 May 2019 11:00:28 +0800 > Fix gcc build error: > > net/dsa/tag_brcm.c:211:16: error: brcm_prepend_netdev_ops undeclared here (not in a function); did you mean brcm_netdev_ops? > DSA_TAG_DRIVER(brcm_prepend_netdev_ops); > ^ > ./include/net/dsa.h:708:10: note: in definition of macro DSA_TAG_DRIVER > .ops = &__ops, \ > ^~~~~ > ./include/net/dsa.h:701:36: warning: dsa_tag_driver_brcm_prepend_netdev_ops defined but not used [-Wunused-variable] > #define DSA_TAG_DRIVER_NAME(__ops) dsa_tag_driver ## _ ## __ops > ^ > ./include/net/dsa.h:707:30: note: in expansion of macro DSA_TAG_DRIVER_NAME > static struct dsa_tag_driver DSA_TAG_DRIVER_NAME(__ops) = { \ > ^~~~~~~~~~~~~~~~~~~ > net/dsa/tag_brcm.c:211:1: note: in expansion of macro DSA_TAG_DRIVER > DSA_TAG_DRIVER(brcm_prepend_netdev_ops); > > Like the CONFIG_NET_DSA_TAG_BRCM case, > brcm_prepend_netdev_ops and DSA_TAG_PROTO_BRCM_PREPEND > should be wrappeed by CONFIG_NET_DSA_TAG_BRCM_PREPEND. > > Reported-by: Hulk Robot <hulkci@...wei.com> > Fixes: b74b70c44986 ("net: dsa: Support prepended Broadcom tag") > Signed-off-by: YueHaibing <yuehaibing@...wei.com> Applied and queued up for -stable.
Powered by blists - more mailing lists