netdev - RE: [PATCH net 1/2] net/tls: remove set but not used variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cd58396644c1_61292af501ab05c450@john-XPS-13-9360.notmuch>
Date:   Fri, 10 May 2019 06:58:46 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Vakul Garg <vakul.garg@....com>,
        Boris Pismenny <borisp@...lanox.com>,
        Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
Subject: RE: [PATCH net 1/2] net/tls: remove set but not used variables

Jakub Kicinski wrote:
> Commit 4504ab0e6eb8 ("net/tls: Inform user space about send buffer availability")
> made us report write_space regardless whether partial record
> push was successful or not.  Remove the now unused return value
> to clean up the following W=1 warning:
> 
> net/tls/tls_device.c: In function ‘tls_device_write_space’:
> net/tls/tls_device.c:546:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
>   int rc = 0;
>       ^~
> 
> CC: Vakul Garg <vakul.garg@....com>
> CC: Boris Pismenny <borisp@...lanox.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
> ---
>  net/tls/tls_device.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 

Acked-by: John Fastabend <john.fastabend@...il.com>