lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 May 2019 09:53:52 -0700 From: Jakub Kicinski <jakub.kicinski@...ronome.com> To: John Fastabend <john.fastabend@...il.com> Cc: ast@...nel.org, daniel@...earbox.net, netdev@...r.kernel.org, bpf@...r.kernel.org Subject: Re: [bpf PATCH v4 1/4] bpf: tls, implement unhash to avoid transition out of ESTABLISHED On Thu, 09 May 2019 21:57:49 -0700, John Fastabend wrote: > #ifdef CONFIG_TLS_DEVICE > if (ctx->rx_conf == TLS_HW) > tls_device_offload_cleanup_rx(sk); > - > - if (ctx->tx_conf != TLS_HW && ctx->rx_conf != TLS_HW) { > -#else > - { > #endif > + > + if (ctx->tx_conf != TLS_HW && ctx->rx_conf != TLS_HW) Did you try to build without CONFIG_TLS_DEVICE? I think someone spent too much time in Verilog land and decided it's a good idea to hide enum values under an ifdef: $ git grep -C4 TLS_HW, include/net/tls.h-enum { include/net/tls.h- TLS_BASE, include/net/tls.h- TLS_SW, include/net/tls.h-#ifdef CONFIG_TLS_DEVICE include/net/tls.h: TLS_HW, include/net/tls.h-#endif include/net/tls.h- TLS_HW_RECORD, include/net/tls.h- TLS_NUM_CONFIG, include/net/tls.h-}; :( > + return true; > + return false; > +}
Powered by blists - more mailing lists