lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 13 May 2019 09:01:14 +0200
From:   Geert Uytterhoeven <>
To:     "Alastair D'Silva" <>
Cc:, Jani Nikula <>,
        Joonas Lahtinen <>,
        Rodrigo Vivi <>,
        David Airlie <>,
        Daniel Vetter <>,
        Dan Carpenter <>,
        Karsten Keil <>,
        Jassi Brar <>,
        Tom Lendacky <>,
        "David S. Miller" <>,
        Jose Abreu <>,
        Kalle Valo <>,
        Stanislaw Gruszka <>,
        Benson Leung <>,
        Enric Balletbo i Serra <>,
        "James E.J. Bottomley" <>,
        "Martin K. Petersen" <>,
        Greg Kroah-Hartman <>,
        Alexander Viro <>,
        Petr Mladek <>,
        Sergey Senozhatsky <>,
        Steven Rostedt <>,
        David Laight <>,
        Andrew Morton <>,
        Intel Graphics Development <>,
        DRI Development <>,
        Linux Kernel Mailing List <>,
        netdev <>,,
        linux-wireless <>,
        scsi <>,
        Linux Fbdev development list <>,
        driverdevel <>,
        Linux FS Devel <>
Subject: Re: [PATCH v2 3/7] lib/hexdump.c: Optionally suppress lines of
 repeated bytes

Hi Alastair,

Thanks for your patch!

On Wed, May 8, 2019 at 9:04 AM Alastair D'Silva <> wrote:
> From: Alastair D'Silva <>
> Some buffers may only be partially filled with useful data, while the rest
> is padded (typically with 0x00 or 0xff).
> This patch introduces a flag to allow the supression of lines of repeated
> bytes,

Given print_hex_dump() operates on entities of groupsize (1, 2, 4, or 8)
bytes, wouldn't it make more sense to consider repeated groups instead
of repeated bytes?

> which are replaced with '** Skipped %u bytes of value 0x%x **'

Using a custom message instead of just "*", like "hexdump" uses, will
require preprocessing the output when recovering the original binary
data by feeding it to e.g. "xxd".
This may sound worse than it is, though, as I never got "xxd" to work
without preprocessing anyway ;-)

    $ cat $(type -p unhexdump)
    sed 's/^[0-9a-f]*//' $1 | xxd -r -p | dd conv=swab



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Powered by blists - more mailing lists